Skip to content

_stage: use 16 bit for coordinates to support larger screens#667

Merged
dhalbert merged 1 commit into
adafruit:2.xfrom
python-ugame:2.x
Mar 12, 2018
Merged

_stage: use 16 bit for coordinates to support larger screens#667
dhalbert merged 1 commit into
adafruit:2.xfrom
python-ugame:2.x

Conversation

@deshipu
Copy link
Copy Markdown

@deshipu deshipu commented Mar 11, 2018

No description provided.

@dhalbert
Copy link
Copy Markdown
Collaborator

Do the x,y and width,height types in Layer.h and Text.h need to change as well?

@tannewt tannewt requested a review from dhalbert March 12, 2018 20:34
@tannewt tannewt added this to the 2.x milestone Mar 12, 2018
@deshipu
Copy link
Copy Markdown
Author

deshipu commented Mar 12, 2018

No, those are in tiles (16×16), not pixels, so they are fine at least until we have 4096×4096 screens (and enough memory to handle them).

Copy link
Copy Markdown
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@dhalbert dhalbert merged commit cfcbb36 into adafruit:2.x Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants